Skip to content

[DO NOT MERGE] Resolve "Wrong scaling of lowrate_pitchGain, affecting speech_music_classif_fx"

Vladimir Malenovskyrequested to merge
basop-2282-wrong-scaling-of-lowrate_pitchgain-affecting-speech_music_classif_fx into main

Reason why this change is needed

In the EVS encoder, we compute the lowrate_pitchGain to be used inside the speech music classifier. In EVS the computation of that gain is done in Q15 but the comparison in the classifier is performed in Q14.

hSpMusClas->lowrate_pitchGain = round_fx_sat( L_mac_sat( L_mult( 29491, hSpMusClas->lowrate_pitchGain ), 6554, gain_pit_fx ) ); /_Q14_Q16(0.1) + Q15 -> Q15*/

while it should be

hSpMusClas->lowrate_pitchGain = round_fx_sat( L_mac_sat( L_mult( 29491, hSpMusClas->lowrate_pitchGain ), 3277, gain_pit_fx ) ); /* Q14_Q15 + Q14 -> Q14 lowrate_pitchGain is compared to Q14 in sp_music_classif_/

Description of the change

Change the constant 6554 (0.1 in Q13) to 3277 (0.1 in Q15)

Affected operating points

This affects only EVS.

Closes #2282 (closed)

Merge request reports