Skip to content

Wrong scaling of lowrate_pitchGain, affecting speech_music_classif_fx

Basic info

  • Float reference:
    • Encoder (float):
    • Decoder (float):
  • Fixed point:
    • Encoder (fixed):
    • Decoder (fixed):

Bug description

In the EVS encoder, we compute the lowrate_pitchGain to be used inside the speech music classifier. In EVS the computation of that gain is done in Q15 but the comparison in the classifier is performed in Q14.

hSpMusClas->lowrate_pitchGain = round_fx_sat( L_mac_sat( L_mult( 29491, hSpMusClas->lowrate_pitchGain ), 6554, gain_pit_fx ) ); /_Q14_Q16(0.1) + Q15 -> Q15*/

while it should be

hSpMusClas->lowrate_pitchGain = round_fx_sat( L_mac_sat( L_mult( 29491, hSpMusClas->lowrate_pitchGain ), 3277, gain_pit_fx ) ); /* Q14_Q15 + Q14 -> Q14 lowrate_pitchGain is compared to Q14 in sp_music_classif_/

This affect only EVS

@malenovskyvl , as you are the one with the better knowledge of the classifier, can you set the priority level please

Ways to reproduce

Box folder: ...\Box_EXTERNAL_IVAS_BASOP_VERIFICATION\issues\issue-xxxx