Skip to content

Draft: basop-2261- remove unnecessary Aq scaling [non-BE][Split non-BE]

vaillancourrequested to merge
2261-avoid-redundant-lpc-coefficient-rescaling-to-q12-to-preserve-precision into main
  • Related issues: #2261
  • Requested reviewers:

Reason why this change is needed

  • In the encoder, LPC filter coefficients are repeatedly rescaled to Q12 format, even though the sub-functions already handle different scaling internally. This redundant rescaling introduces unnecessary complexity and results in a loss of precision.

Description of the change

  • Remove of unnecessary LP coefficient rescaling

Affected operating points

  • Every bitrate that uses LP coefficients (mainly ACELP, TCX)
  • Produced bitstream is non-BE but it is fully backwards compatible for decoding. Decoded output may differ.
  • For output difference, use BE or non-BE. Additionally, amount of difference can be presented.
    • Non BE, difference can be large given this affects ACELP close loop.

Closes #2261

Merge request reports