From 935c8e25356a3646b8f0cb51ee76d7c8c8416cff Mon Sep 17 00:00:00 2001 From: Tommy Vaillancourt Date: Fri, 12 Dec 2025 10:25:37 -0500 Subject: [PATCH 1/2] fix for 2268, to silence clang18, will add some complexity to the ifft --- lib_com/ifft_rel_fx.c | 7 ++++++- lib_com/options.h | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/lib_com/ifft_rel_fx.c b/lib_com/ifft_rel_fx.c index 450e9195e..12af0e14a 100644 --- a/lib_com/ifft_rel_fx.c +++ b/lib_com/ifft_rel_fx.c @@ -139,7 +139,12 @@ void ifft_rel_fx( /*Can be acheived with a shr */ step = idiv1616( N_MAX_SAS, n2 ); move16(); - +#ifdef FIX_2268_OOB_INDEXING_IN_IFFT + IF( LT_16( n8, 2) ) + { + continue; + } +#endif s = sincos_t_fx + step; /*Q15 */ c = s + 64; /*Q15 */ s3 = sincos_t_fx + i_mult2( step, 3 ); /*Q15 */ diff --git a/lib_com/options.h b/lib_com/options.h index ee8c6be3a..976fdb89f 100644 --- a/lib_com/options.h +++ b/lib_com/options.h @@ -89,7 +89,7 @@ #define FIX_2252_SCALING_SAVE_HB_SYNTH /* VA: issue 2252: fix use-of-uninit-value in save_hb_synth_fx[] scaling in FOA decoding with bitstream that starts with an SID */ #define FIX_2248_EVS_ASSERT /* VA: Include _sat in an EVS related part of the code */ #define FIX_2254_IMPROV_COMPLEXITY_BE /* VA: BE small complexity reduction */ - +#define FIX_2268_OOB_INDEXING_IN_IFFT /* VA: Fix for issue 2268, to silence clang18 */ /* #################### End BE switches ################################## */ /* #################### Start NON-BE switches ############################ */ -- GitLab From 5f80e33373ec5ff213010e77585ef93bd950270d Mon Sep 17 00:00:00 2001 From: Tommy Vaillancourt Date: Fri, 12 Dec 2025 11:03:04 -0500 Subject: [PATCH 2/2] fix clang --- lib_com/ifft_rel_fx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib_com/ifft_rel_fx.c b/lib_com/ifft_rel_fx.c index 12af0e14a..d11e07baa 100644 --- a/lib_com/ifft_rel_fx.c +++ b/lib_com/ifft_rel_fx.c @@ -140,7 +140,7 @@ void ifft_rel_fx( step = idiv1616( N_MAX_SAS, n2 ); move16(); #ifdef FIX_2268_OOB_INDEXING_IN_IFFT - IF( LT_16( n8, 2) ) + IF( LT_16( n8, 2 ) ) { continue; } -- GitLab