From efd1343638b56e17e4d3e86e1def54b91080a387 Mon Sep 17 00:00:00 2001 From: Marek Szczerba Date: Thu, 10 Jul 2025 15:10:08 +0200 Subject: [PATCH 1/3] [fix] Removed redundant shift of square root function matissa argument --- lib_dec/ivas_binRenderer_internal_fx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib_dec/ivas_binRenderer_internal_fx.c b/lib_dec/ivas_binRenderer_internal_fx.c index 6911e487f..9881ea8dd 100644 --- a/lib_dec/ivas_binRenderer_internal_fx.c +++ b/lib_dec/ivas_binRenderer_internal_fx.c @@ -978,7 +978,7 @@ static void ivas_binaural_obtain_DMX_fx( { Word16 div = divide3232( P_in_fx[bandIdx], P_out_fx ); Word16 exp = norm_l( div ); - factEQ_fx = Sqrt32( L_shl( div, Q16 ), &exp ); + factEQ_fx = Sqrt32( div, &exp ); factEQ_fx = L_shl( factEQ_fx, sub( exp, 1 ) ); // Q30 } if ( factEQ_fx <= 0 ) -- GitLab From 465ce4914bb97beb069ade778ed726ad9147bd79 Mon Sep 17 00:00:00 2001 From: Marek Szczerba Date: Wed, 13 Aug 2025 13:14:58 +0200 Subject: [PATCH 2/3] Update reflecting review remarks provided --- lib_dec/ivas_binRenderer_internal_fx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib_dec/ivas_binRenderer_internal_fx.c b/lib_dec/ivas_binRenderer_internal_fx.c index 3d9fd515c..8f9e556a8 100644 --- a/lib_dec/ivas_binRenderer_internal_fx.c +++ b/lib_dec/ivas_binRenderer_internal_fx.c @@ -1059,7 +1059,7 @@ static void ivas_binaural_obtain_DMX_fx( { Word16 div = divide3232( P_in_fx[bandIdx], P_out_fx ); #ifdef FIX_1835_REVERB_ACTIVATION - Word16 exp = 0; // divide3232 returns Q15 + following Q16 shift + Word16 exp = 16; // divide3232 returns Q15 #else Word16 exp = norm_l( div ); #endif -- GitLab From 56249082c8526ece1e3cb0f326458f665af23790 Mon Sep 17 00:00:00 2001 From: Tapani Pihlajakuja Date: Wed, 20 Aug 2025 16:39:11 +0300 Subject: [PATCH 3/3] Remove switch that was already accepted. --- lib_dec/ivas_binRenderer_internal_fx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib_dec/ivas_binRenderer_internal_fx.c b/lib_dec/ivas_binRenderer_internal_fx.c index e99f543a1..4ee8f9f4d 100644 --- a/lib_dec/ivas_binRenderer_internal_fx.c +++ b/lib_dec/ivas_binRenderer_internal_fx.c @@ -981,11 +981,7 @@ static void ivas_binaural_obtain_DMX_fx( ELSE { Word16 div = divide3232( P_in_fx[bandIdx], P_out_fx ); -#ifdef FIX_1835_REVERB_ACTIVATION Word16 exp = 16; // divide3232 returns Q15 -#else - Word16 exp = norm_l( div ); -#endif factEQ_fx = Sqrt32( div, &exp ); factEQ_fx = L_shl( factEQ_fx, sub( exp, 1 ) ); // Q30 } -- GitLab