From 140b840eab6aef97e448af30be69e66054fbd7f1 Mon Sep 17 00:00:00 2001 From: hawbakert Date: Wed, 16 Oct 2024 13:12:53 +0000 Subject: [PATCH 1/8] FirstRun R19IMSDataChannel --- 33128/r19/TS33128Payloads.asn | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/33128/r19/TS33128Payloads.asn b/33128/r19/TS33128Payloads.asn index 182730dd..b1bd80b4 100644 --- a/33128/r19/TS33128Payloads.asn +++ b/33128/r19/TS33128Payloads.asn @@ -278,7 +278,11 @@ XIRIEvent ::= CHOICE uDMProSeTargetAuthentication [160] UDMProSeTargetAuthentication, -- IP Packet Report, see clause 6.2.3.9.5 - iPIRIPacketReport [161] IPAccessPDU.IPIRIPacketReport + iPIRIPacketReport [161] IPAccessPDU.IPIRIPacketReport, + + -- IMS events, see clause 7.12.4.2, continued from tag 107 + iMSDataChannelSetup [162] IMSDataChannelSetup, + iMSDataChannelTermination [163] IMSDataChannelTermination } -- ============== @@ -538,9 +542,13 @@ IRIEvent ::= CHOICE -- UDM events, see clause 7.2.2.3, continued from tag 124 uDMProSeTargetIdentifierDeconcealment [159] UDMProSeTargetIdentifierDeconcealment, - uDMProSeTargetAuthentication [160] UDMProSeTargetAuthentication + uDMProSeTargetAuthentication [160] UDMProSeTargetAuthentication, -- Tag 161 is reserved because there is no equivalent IP Packet Report in IRIEvent. + + -- IMS events, see clause 7.12.7, continued from tag 107 + iMSDataChannelSetup [162] IMSDataChannelSetup, + iMSDataChannelTermination [163] IMSDataChannelTermination } IRITargetIdentifier ::= SEQUENCE @@ -4532,6 +4540,24 @@ IMSCCUnavailable ::= SEQUENCE sDPState [2] OCTET STRING OPTIONAL } +-- See clause 7.12.4.2.X for details of this structure +IMSDataChannelSetup ::= SEQUENCE +{ + originatingId [1] SEQUENCE OF IMPU, + terminatingId [2] SEQUENCE OF IMPU, + sessionEventNotification [3] SBIType OPTIONAL, + mediaInstructionData [4] SBIType OPTIONAL +} + +-- See Clause 7.12.4.2.Y for details of this structure +IMSDataChannelTermination ::= SEQUENCE +{ + originatingId [1] SEQUENCE OF IMPU, + terminatingId [2] SEQUENCE OF IMPU, + sessionEventNotification [3] SBIType OPTIONAL, + mediaInstructionData [4] SBIType OPTIONAL +} + -- ========= -- IMS CCPDU -- ========= -- GitLab From 42f38029c6f04b1418981cf6bb58716cad2e945a Mon Sep 17 00:00:00 2001 From: hawbakert Date: Wed, 16 Oct 2024 13:23:12 +0000 Subject: [PATCH 2/8] Update file TS33128Payloads.asn --- 33128/r19/TS33128Payloads.asn | 1 + 1 file changed, 1 insertion(+) diff --git a/33128/r19/TS33128Payloads.asn b/33128/r19/TS33128Payloads.asn index b1bd80b4..39093157 100644 --- a/33128/r19/TS33128Payloads.asn +++ b/33128/r19/TS33128Payloads.asn @@ -545,6 +545,7 @@ IRIEvent ::= CHOICE uDMProSeTargetAuthentication [160] UDMProSeTargetAuthentication, -- Tag 161 is reserved because there is no equivalent IP Packet Report in IRIEvent. + reserved [161] Reserved, -- IMS events, see clause 7.12.7, continued from tag 107 iMSDataChannelSetup [162] IMSDataChannelSetup, -- GitLab From bb3732f1ec18b8edf65a393f1f427e925b80c6de Mon Sep 17 00:00:00 2001 From: mark Date: Wed, 16 Oct 2024 14:36:27 +0100 Subject: [PATCH 3/8] Removing reserved ASN.1 tag --- 33128/r19/TS33128Payloads.asn | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/33128/r19/TS33128Payloads.asn b/33128/r19/TS33128Payloads.asn index 39093157..c0b9a023 100644 --- a/33128/r19/TS33128Payloads.asn +++ b/33128/r19/TS33128Payloads.asn @@ -545,8 +545,7 @@ IRIEvent ::= CHOICE uDMProSeTargetAuthentication [160] UDMProSeTargetAuthentication, -- Tag 161 is reserved because there is no equivalent IP Packet Report in IRIEvent. - reserved [161] Reserved, - + -- IMS events, see clause 7.12.7, continued from tag 107 iMSDataChannelSetup [162] IMSDataChannelSetup, iMSDataChannelTermination [163] IMSDataChannelTermination -- GitLab From bf6df84de819433c7d78e9ea12be43eb93ca5e9e Mon Sep 17 00:00:00 2001 From: mark Date: Wed, 16 Oct 2024 14:37:17 +0100 Subject: [PATCH 4/8] Adding linting exception (again) --- testing/asn_lint_exceptions.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/testing/asn_lint_exceptions.json b/testing/asn_lint_exceptions.json index 7bafe4ba..300225ca 100644 --- a/testing/asn_lint_exceptions.json +++ b/testing/asn_lint_exceptions.json @@ -86,6 +86,7 @@ "Tag 6 missing in LALSReport", "Tag 8 missing in MMEStartOfInterceptionWithEPSAttachedUE", "Tag 11 missing in MMEStartOfInterceptionWithEPSAttachedUE", - "Tag 161 XIRIEvent field 'iPIRIPacketReport' is not present in IRIEvent" + "Tag 161 XIRIEvent field 'iPIRIPacketReport' is not present in IRIEvent", + "Tag 161 missing in IRIEvent" ] } -- GitLab From 7fe9097ff8fff8ef660b593b5b4654eb9a24d2e3 Mon Sep 17 00:00:00 2001 From: mark Date: Wed, 16 Oct 2024 14:39:35 +0100 Subject: [PATCH 5/8] Fixing editorconfig linting error --- 33128/r19/TS33128Payloads.asn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/33128/r19/TS33128Payloads.asn b/33128/r19/TS33128Payloads.asn index c0b9a023..b1bd80b4 100644 --- a/33128/r19/TS33128Payloads.asn +++ b/33128/r19/TS33128Payloads.asn @@ -545,7 +545,7 @@ IRIEvent ::= CHOICE uDMProSeTargetAuthentication [160] UDMProSeTargetAuthentication, -- Tag 161 is reserved because there is no equivalent IP Packet Report in IRIEvent. - + -- IMS events, see clause 7.12.7, continued from tag 107 iMSDataChannelSetup [162] IMSDataChannelSetup, iMSDataChannelTermination [163] IMSDataChannelTermination -- GitLab From 945ec66694dfefe726839171e6e5d454e7dfbe4e Mon Sep 17 00:00:00 2001 From: hawbakert Date: Thu, 31 Oct 2024 19:37:31 +0000 Subject: [PATCH 6/8] Update file TS33128Payloads.asn --- 33128/r19/TS33128Payloads.asn | 36 ++++++++++++++++++++++++----------- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/33128/r19/TS33128Payloads.asn b/33128/r19/TS33128Payloads.asn index b1bd80b4..ef62dc17 100644 --- a/33128/r19/TS33128Payloads.asn +++ b/33128/r19/TS33128Payloads.asn @@ -282,7 +282,8 @@ XIRIEvent ::= CHOICE -- IMS events, see clause 7.12.4.2, continued from tag 107 iMSDataChannelSetup [162] IMSDataChannelSetup, - iMSDataChannelTermination [163] IMSDataChannelTermination + iMSDataChannelModification [163] IMSDataChannelModification, + iMSDataChannelTermination [164] IMSDataChannelTermination } -- ============== @@ -548,7 +549,8 @@ IRIEvent ::= CHOICE -- IMS events, see clause 7.12.7, continued from tag 107 iMSDataChannelSetup [162] IMSDataChannelSetup, - iMSDataChannelTermination [163] IMSDataChannelTermination + iMSDataChannelModification [163] IMSDataChannelModification, + iMSDataChannelTermination [164] IMSDataChannelTermination } IRITargetIdentifier ::= SEQUENCE @@ -4543,19 +4545,31 @@ IMSCCUnavailable ::= SEQUENCE -- See clause 7.12.4.2.X for details of this structure IMSDataChannelSetup ::= SEQUENCE { - originatingId [1] SEQUENCE OF IMPU, - terminatingId [2] SEQUENCE OF IMPU, - sessionEventNotification [3] SBIType OPTIONAL, - mediaInstructionData [4] SBIType OPTIONAL + targetIdentity [1] IMPU, + callingIdentity [2] IMPU OPTIONAL, + terminatingId [3] SEQUENCE (SIZE (0..MAX)) OF IMPU OPTIONAL, + sessionEventNotification [4] SBIType OPTIONAL, + mediaInstructionData [5] SBIType OPTIONAL } --- See Clause 7.12.4.2.Y for details of this structure +-- See clause 7.12.4.2.Y for details of this structure +IMSDataChannelModification ::= SEQUENCE +{ + targetIdentity [1] IMPU, + callingIdentity [2] IMPU OPTIONAL, + calledIdentity [3] SEQUENCE (SIZE (0..MAX)) OF IMPU OPTIONAL, + sessionEventNotification [4] SBIType OPTIONAL, + mediaInstructions [5] SBIType OPTIONAL +} + +-- See Clause 7.12.4.2.Z for details of this structure IMSDataChannelTermination ::= SEQUENCE { - originatingId [1] SEQUENCE OF IMPU, - terminatingId [2] SEQUENCE OF IMPU, - sessionEventNotification [3] SBIType OPTIONAL, - mediaInstructionData [4] SBIType OPTIONAL + targetIdentity [1] IMPU, + callingIdentity [2] IMPU OPTIONAL, + calledIdentity [3] SEQUENCE (SIZE (0..MAX)) OF IMPU OPTIONAL, + sessionEventNotification [4] SBIType OPTIONAL, + mediaInstructionData [5] SBIType OPTIONAL } -- ========= -- GitLab From 33d8abcccf25ebf5bede2fcfc3702cd8d15ef430 Mon Sep 17 00:00:00 2001 From: hawbakert Date: Thu, 31 Oct 2024 23:03:13 +0000 Subject: [PATCH 7/8] Update file TS33128Payloads.asn --- 33128/r19/TS33128Payloads.asn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/33128/r19/TS33128Payloads.asn b/33128/r19/TS33128Payloads.asn index ef62dc17..5bf94b23 100644 --- a/33128/r19/TS33128Payloads.asn +++ b/33128/r19/TS33128Payloads.asn @@ -4547,7 +4547,7 @@ IMSDataChannelSetup ::= SEQUENCE { targetIdentity [1] IMPU, callingIdentity [2] IMPU OPTIONAL, - terminatingId [3] SEQUENCE (SIZE (0..MAX)) OF IMPU OPTIONAL, + calledIdentity [3] SEQUENCE (SIZE (0..MAX)) OF IMPU OPTIONAL, sessionEventNotification [4] SBIType OPTIONAL, mediaInstructionData [5] SBIType OPTIONAL } -- GitLab From 3ad7bf30e7a256b2d7159523ecab7bd03a2a12d8 Mon Sep 17 00:00:00 2001 From: hawbakert Date: Fri, 1 Nov 2024 01:04:31 +0000 Subject: [PATCH 8/8] Update file TS33128Payloads.asn --- 33128/r19/TS33128Payloads.asn | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/33128/r19/TS33128Payloads.asn b/33128/r19/TS33128Payloads.asn index 5bf94b23..d4e5927f 100644 --- a/33128/r19/TS33128Payloads.asn +++ b/33128/r19/TS33128Payloads.asn @@ -4547,7 +4547,7 @@ IMSDataChannelSetup ::= SEQUENCE { targetIdentity [1] IMPU, callingIdentity [2] IMPU OPTIONAL, - calledIdentity [3] SEQUENCE (SIZE (0..MAX)) OF IMPU OPTIONAL, + calledIdentity [3] SEQUENCE (SIZE (1..MAX)) OF IMPU OPTIONAL, sessionEventNotification [4] SBIType OPTIONAL, mediaInstructionData [5] SBIType OPTIONAL } @@ -4557,7 +4557,7 @@ IMSDataChannelModification ::= SEQUENCE { targetIdentity [1] IMPU, callingIdentity [2] IMPU OPTIONAL, - calledIdentity [3] SEQUENCE (SIZE (0..MAX)) OF IMPU OPTIONAL, + calledIdentity [3] SEQUENCE (SIZE (1..MAX)) OF IMPU OPTIONAL, sessionEventNotification [4] SBIType OPTIONAL, mediaInstructions [5] SBIType OPTIONAL } @@ -4567,7 +4567,7 @@ IMSDataChannelTermination ::= SEQUENCE { targetIdentity [1] IMPU, callingIdentity [2] IMPU OPTIONAL, - calledIdentity [3] SEQUENCE (SIZE (0..MAX)) OF IMPU OPTIONAL, + calledIdentity [3] SEQUENCE (SIZE (1..MAX)) OF IMPU OPTIONAL, sessionEventNotification [4] SBIType OPTIONAL, mediaInstructionData [5] SBIType OPTIONAL } -- GitLab