From b3094dfb6c0069dca90f9be0dc84ce7727820d89 Mon Sep 17 00:00:00 2001 From: veeravt Date: Thu, 27 Apr 2023 17:35:47 +0200 Subject: [PATCH 1/2] Check for a bug free version of gen-patt. --- .../audiotools/wrappers/gen_patt.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/ivas_processing_scripts/audiotools/wrappers/gen_patt.py b/ivas_processing_scripts/audiotools/wrappers/gen_patt.py index 2b78d16e..cff13528 100644 --- a/ivas_processing_scripts/audiotools/wrappers/gen_patt.py +++ b/ivas_processing_scripts/audiotools/wrappers/gen_patt.py @@ -131,6 +131,16 @@ def create_error_pattern( Number of preruns in seed generation """ + # checking if the gen-patt version is bug free + with TemporaryDirectory() as tmp_dir_test: + tmp_dir_test = Path(tmp_dir_test) + tmp_sta_file_test = tmp_dir_test.joinpath("sta") + gen_patt(100, "ep.g192", 5, working_dir=tmp_dir_test) + if not tmp_sta_file_test.exists(): + raise FileNotFoundError( + "A non-working version of gen-patt was detected. Replace it with a bug-free version." + ) + with TemporaryDirectory() as tmp_dir: tmp_dir = Path(tmp_dir) -- GitLab From deef94e943a224319e3863f1db0269fb62564d53 Mon Sep 17 00:00:00 2001 From: Markus Multrus Date: Thu, 27 Apr 2023 23:32:33 +0200 Subject: [PATCH 2/2] improve error message --- ivas_processing_scripts/audiotools/wrappers/gen_patt.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ivas_processing_scripts/audiotools/wrappers/gen_patt.py b/ivas_processing_scripts/audiotools/wrappers/gen_patt.py index cff13528..f801b07b 100644 --- a/ivas_processing_scripts/audiotools/wrappers/gen_patt.py +++ b/ivas_processing_scripts/audiotools/wrappers/gen_patt.py @@ -137,8 +137,8 @@ def create_error_pattern( tmp_sta_file_test = tmp_dir_test.joinpath("sta") gen_patt(100, "ep.g192", 5, working_dir=tmp_dir_test) if not tmp_sta_file_test.exists(): - raise FileNotFoundError( - "A non-working version of gen-patt was detected. Replace it with a bug-free version." + raise RuntimeError( + "Used version of gen-patt was detected to be faulty (unable to write \"sta\"-file). See bin/README.md for details." ) with TemporaryDirectory() as tmp_dir: -- GitLab