From bb3c31b0e4fba1760cf248fd965766109dcdd6ed Mon Sep 17 00:00:00 2001 From: Charles Kinuthia Date: Thu, 17 Aug 2023 07:52:05 +0200 Subject: [PATCH 1/3] fix syntax for exit condition in check-first-frame-is-sid job --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 9a69b946bd..86ad5201e7 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -833,7 +833,7 @@ check-first-frame-is-sid: - scripts/runIvasCodec.py -p scripts/config/ci_linux_sidstart_test.json -m $modes -s --bs_length 500 -U 0:20 || exit_code_no_sba=$? - modes=$(scripts/runIvasCodec.py -l | grep dtx | grep SBA) - scripts/runIvasCodec.py -p scripts/config/ci_linux_sidstart_test.json -m $modes -s --bs_length 500 -U 70:80 || exit_code_sba=$? - - if [ $exit_code_no_sba != 0 || $exit_code_sba != 0 ]; then exit 1; fi + - if [ $exit_code_no_sba != 0 ] || [ $exit_code_sba != 0 ]; then exit 1; fi artifacts: paths: - out/logs -- GitLab From f87d645a5e8a681b975324331d2dc69dd6f0f63e Mon Sep 17 00:00:00 2001 From: Charles Kinuthia Date: Thu, 17 Aug 2023 10:48:16 +0200 Subject: [PATCH 2/3] use -ne for comparison in exit condition for check-first-frame-is-sid --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 86ad5201e7..51422b6fb8 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -833,7 +833,7 @@ check-first-frame-is-sid: - scripts/runIvasCodec.py -p scripts/config/ci_linux_sidstart_test.json -m $modes -s --bs_length 500 -U 0:20 || exit_code_no_sba=$? - modes=$(scripts/runIvasCodec.py -l | grep dtx | grep SBA) - scripts/runIvasCodec.py -p scripts/config/ci_linux_sidstart_test.json -m $modes -s --bs_length 500 -U 70:80 || exit_code_sba=$? - - if [ $exit_code_no_sba != 0 ] || [ $exit_code_sba != 0 ]; then exit 1; fi + - if [ $exit_code_no_sba -ne 0 ] || [ $exit_code_sba -ne 0 ]; then exit 1; fi artifacts: paths: - out/logs -- GitLab From b4e7807d8606d33cabd5b235e8a77abc199e5c62 Mon Sep 17 00:00:00 2001 From: Charles Kinuthia Date: Thu, 17 Aug 2023 11:15:16 +0200 Subject: [PATCH 3/3] initialize exit_code_no_sba and exit_code_sba to 0 --- .gitlab-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 51422b6fb8..37a8500114 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -829,6 +829,8 @@ check-first-frame-is-sid: # TODO: for some MASA modes, we currently do not have testvectors that actually trigger DTX # SBA is run separately to use shorter part of file + - exit_code_no_sba=0 + - exit_code_sba=0 - modes=$(scripts/runIvasCodec.py -l | grep dtx | grep -v MASA | grep -v SBA) - scripts/runIvasCodec.py -p scripts/config/ci_linux_sidstart_test.json -m $modes -s --bs_length 500 -U 0:20 || exit_code_no_sba=$? - modes=$(scripts/runIvasCodec.py -l | grep dtx | grep SBA) -- GitLab