From caeb93db6ed251c384c5672f0ed7fdf253fe2c21 Mon Sep 17 00:00:00 2001 From: malenov Date: Thu, 27 Jul 2023 12:21:25 +0200 Subject: [PATCH 1/3] remove the comments IVAS-219: QCToDo: --- lib_enc/ivas_stereo_icbwe_enc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib_enc/ivas_stereo_icbwe_enc.c b/lib_enc/ivas_stereo_icbwe_enc.c index 43ae497df8..14bf01e32b 100644 --- a/lib_enc/ivas_stereo_icbwe_enc.c +++ b/lib_enc/ivas_stereo_icbwe_enc.c @@ -417,7 +417,6 @@ void stereo_icBWE_enc( /* core switching reset */ if ( st->last_core != ACELP_CORE || st->core != ACELP_CORE || st->bwidth < SWB || st->extl == -1 ) { - /* IVAS-219: QCToDo: ICBWEDFT for WB TBV */ ic_bwe_enc_reset( hStereoICBWE ); if ( st->core != ACELP_CORE || st->bwidth < SWB || st->input_Fs < 32000 || st->extl == -1 ) { @@ -505,7 +504,6 @@ void stereo_icBWE_enc( mvr2r( shb_frame_nonref + L_FRAME16k, hStereoICBWE->mem_shb_speech_nonref, L_LOOK_16k ); /* core switching reset */ - /* IVAS-219: QCToDo: check this "if condition" if IVAS_CPE_TD is needed? */ if ( st->last_core != ACELP_CORE || st->core != ACELP_CORE || st->bwidth < SWB || st->element_mode != IVAS_CPE_TD || st->extl == -1 ) { ic_bwe_enc_reset( hStereoICBWE ); @@ -517,7 +515,7 @@ void stereo_icBWE_enc( } /* resets done here. Need to move them to a separate function */ - if ( ( hStereoICBWE->prev_refChanIndx_bwe != hStereoICBWE->refChanIndx_bwe ) || ( st->last_extl != st->extl ) || st->flag_ACELP16k != 1 ) /* IVAS-219: QCToDo: dont reset for SWB<->FB */ + if ( ( hStereoICBWE->prev_refChanIndx_bwe != hStereoICBWE->refChanIndx_bwe ) || ( st->last_extl != st->extl ) || st->flag_ACELP16k != 1 ) { hStereoICBWE->prevSpecMapping = 0; hStereoICBWE->memShbSpecMapping = 0; -- GitLab From 1ff945ad659c995a403bafaf0a68b3f39fdbc292 Mon Sep 17 00:00:00 2001 From: malenov Date: Mon, 31 Jul 2023 13:16:35 +0200 Subject: [PATCH 2/3] remove obsolete comment related to IVAS-220 (N dependency on input Fs) --- lib_com/ivas_stereo_ica_com.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib_com/ivas_stereo_ica_com.c b/lib_com/ivas_stereo_ica_com.c index f2fd09eca3..a68a9a709a 100644 --- a/lib_com/ivas_stereo_ica_com.c +++ b/lib_com/ivas_stereo_ica_com.c @@ -77,7 +77,6 @@ static void interpTargetChannel( return; } - /* IVAS-220: QCToDo: (check N for dependency on the inputFs) */ N = L_shift_adapt; factor = ( (float) N ) / abs( d ); interp_factor2 = factor / INTERP_FACTOR1; -- GitLab From 6d197de51354fd7c4d6355815bf22951e9999632 Mon Sep 17 00:00:00 2001 From: Markus Multrus Date: Mon, 31 Jul 2023 23:03:12 +0200 Subject: [PATCH 3/3] fix format --- lib_enc/ivas_stereo_icbwe_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib_enc/ivas_stereo_icbwe_enc.c b/lib_enc/ivas_stereo_icbwe_enc.c index 14bf01e32b..f17786e173 100644 --- a/lib_enc/ivas_stereo_icbwe_enc.c +++ b/lib_enc/ivas_stereo_icbwe_enc.c @@ -515,7 +515,7 @@ void stereo_icBWE_enc( } /* resets done here. Need to move them to a separate function */ - if ( ( hStereoICBWE->prev_refChanIndx_bwe != hStereoICBWE->refChanIndx_bwe ) || ( st->last_extl != st->extl ) || st->flag_ACELP16k != 1 ) + if ( ( hStereoICBWE->prev_refChanIndx_bwe != hStereoICBWE->refChanIndx_bwe ) || ( st->last_extl != st->extl ) || st->flag_ACELP16k != 1 ) { hStereoICBWE->prevSpecMapping = 0; hStereoICBWE->memShbSpecMapping = 0; -- GitLab