From 51704a5da7ed17583ceaef76a96c206cdfc5938c Mon Sep 17 00:00:00 2001 From: knj Date: Mon, 26 Feb 2024 08:15:56 +0100 Subject: [PATCH 1/7] increase timeout of scheduled sanitizer tests --- ci/run_scheduled_sanitizer_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/run_scheduled_sanitizer_test.py b/ci/run_scheduled_sanitizer_test.py index 6692c94d7c..d8986233fb 100755 --- a/ci/run_scheduled_sanitizer_test.py +++ b/ci/run_scheduled_sanitizer_test.py @@ -55,7 +55,7 @@ GENPATT_CMD = f"gen-patt -tailstat -fer -g192 -gamma 0 -rate 0.15 -tol 0.001 -re MC_MODES = ["5_1", "5_1_2", "5_1_4", "7_1", "7_1_4"] AMBISONICS_MODES = ["HOA3", "HOA2", "FOA", "PlanarHOA3", "PlanarHOA2", "PlanarFOA"] TIMEOUT = ( - 60 * 15 + 60 * 20 ) # timeout of 15 minutes per en/decoding to safeguard against endless loops CONSOLE_OUT_FILE = "output_san.txt" -- GitLab From 3d06fbbe503aa936a9527581695be32cbb6edb93 Mon Sep 17 00:00:00 2001 From: knj Date: Mon, 26 Feb 2024 08:20:24 +0100 Subject: [PATCH 2/7] move stage to template and remove needs --- .gitlab-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 9344bda913..6e4af2b332 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -191,8 +191,6 @@ stages: # to be reused in MR and LTV-scheduled sanitizer test jobs # set CLANG_NUM, SELFTEST_SANITY_TIMEOUT and SELF_TEST_PRM_FILE in before_script section .sanitizer-selftest-anchor: &sanitizer-selftest-anchor - stage: test - needs: ["build-codec-sanitizers-linux"] script: - *print-common-info - *copy-ltv-files-to-testv-dir @@ -272,6 +270,7 @@ stages: - cp -r scripts/testv/* $TESTV_DIR/ .sanitizer-selftest-on-mr: + stage: test extends: - .test-job-linux-needs-testv-dir - .rules-merge-request @@ -288,6 +287,7 @@ stages: - report-junit.xml .sanitizer-selftest-ltv: + stage: test extends: - .test-job-linux-needs-testv-dir artifacts: -- GitLab From aff6e83057097dd8f7a26f500d868ed0fec2160c Mon Sep 17 00:00:00 2001 From: knj Date: Mon, 26 Feb 2024 08:28:03 +0100 Subject: [PATCH 3/7] temporarily allow schedules to run on non-main --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 6e4af2b332..92119def79 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -42,7 +42,7 @@ workflow: - if: $CI_PIPELINE_SOURCE == 'push' && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH # Pushes to main variables: IVAS_PIPELINE_NAME: 'Push pipeline: $CI_COMMIT_BRANCH' - - if: $CI_PIPELINE_SOURCE == 'schedule' && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH # Scheduled in main + - if: $CI_PIPELINE_SOURCE == 'schedule' # Scheduled in main variables: IVAS_PIPELINE_NAME: 'Scheduled pipeline: $CI_COMMIT_BRANCH' - if: $CI_PIPELINE_SOURCE == 'web' && $MANUAL_PIPELINE_TYPE == 'default' # for testing -- GitLab From 73dd9802ac965fb7368a1156d79cb7a37d2a8118 Mon Sep 17 00:00:00 2001 From: knj Date: Mon, 26 Feb 2024 08:35:14 +0100 Subject: [PATCH 4/7] Revert "temporarily allow schedules to run on non-main" This reverts commit aff6e83057097dd8f7a26f500d868ed0fec2160c. --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 92119def79..6e4af2b332 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -42,7 +42,7 @@ workflow: - if: $CI_PIPELINE_SOURCE == 'push' && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH # Pushes to main variables: IVAS_PIPELINE_NAME: 'Push pipeline: $CI_COMMIT_BRANCH' - - if: $CI_PIPELINE_SOURCE == 'schedule' # Scheduled in main + - if: $CI_PIPELINE_SOURCE == 'schedule' && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH # Scheduled in main variables: IVAS_PIPELINE_NAME: 'Scheduled pipeline: $CI_COMMIT_BRANCH' - if: $CI_PIPELINE_SOURCE == 'web' && $MANUAL_PIPELINE_TYPE == 'default' # for testing -- GitLab From d92bf72493e8ef68dc6ccd42305d764910f33b27 Mon Sep 17 00:00:00 2001 From: knj Date: Mon, 26 Feb 2024 08:49:14 +0100 Subject: [PATCH 5/7] update sanitizer issue tempalte --- .gitlab/issue_templates/sanitizer_error.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/issue_templates/sanitizer_error.md b/.gitlab/issue_templates/sanitizer_error.md index e5b42ba2f4..f442519aba 100644 --- a/.gitlab/issue_templates/sanitizer_error.md +++ b/.gitlab/issue_templates/sanitizer_error.md @@ -28,7 +28,7 @@ or directly: make clean make -j CLANG=X ./IVAS_cod ... -eid-xor -vbr -fer bit ep_015.g192 bit_fer +networkSimulator_g192 dly_profile.dat bit bit_err trace_dump 1 ./IVAS_dec ... ``` -- GitLab From 7bbf0ce9cd320be884f2c242625d468076bad30a Mon Sep 17 00:00:00 2001 From: knj Date: Mon, 26 Feb 2024 08:58:42 +0100 Subject: [PATCH 6/7] add separate issue templates for sanitizer errrors --- .../{sanitizer_error.md => asan_ltv_error.md} | 6 +-- .gitlab/issue_templates/msan_ltv_error.md | 46 +++++++++++++++++++ .gitlab/issue_templates/usan_ltv_error.md | 39 ++++++++++++++++ 3 files changed, 88 insertions(+), 3 deletions(-) rename .gitlab/issue_templates/{sanitizer_error.md => asan_ltv_error.md} (86%) create mode 100644 .gitlab/issue_templates/msan_ltv_error.md create mode 100644 .gitlab/issue_templates/usan_ltv_error.md diff --git a/.gitlab/issue_templates/sanitizer_error.md b/.gitlab/issue_templates/asan_ltv_error.md similarity index 86% rename from .gitlab/issue_templates/sanitizer_error.md rename to .gitlab/issue_templates/asan_ltv_error.md index f442519aba..efb359f539 100644 --- a/.gitlab/issue_templates/sanitizer_error.md +++ b/.gitlab/issue_templates/asan_ltv_error.md @@ -4,7 +4,7 @@ ### Bug description -Clang (m,a,u)san sanitizer test in pipeline found an error: +Clang ASAN sanitizer test in pipeline found an error: ``` @@ -20,13 +20,13 @@ Using the [scripts](https://forge.3gpp.org/rep/ivas-codec-pc/ivas-codec/-/wikis/ ``` -python3 scripts/IvasBuildAndRunChecks.py --checks CLANGX -m MODE -p /path/to/my/local/ci_linux_ltv_local.json --usan_supp_file scripts/ubsan.supp +python3 scripts/IvasBuildAndRunChecks.py --checks CLANG2 -m MODE -p /path/to/my/local/ci_linux_ltv_local.json --usan_supp_file scripts/ubsan.supp ``` or directly: ``` make clean -make -j CLANG=X +make -j CLANG=2 ./IVAS_cod ... networkSimulator_g192 dly_profile.dat bit bit_err trace_dump 1 ./IVAS_dec ... diff --git a/.gitlab/issue_templates/msan_ltv_error.md b/.gitlab/issue_templates/msan_ltv_error.md new file mode 100644 index 0000000000..cc57222658 --- /dev/null +++ b/.gitlab/issue_templates/msan_ltv_error.md @@ -0,0 +1,46 @@ +### Basic info + +- Commit SHA: + +### Bug description + +Clang MSAN sanitizer test in pipeline found an error: + + +``` + +``` + + +Link to test pipeline: XXX + +### Ways to reproduce + +Activate [origin-tracking](https://clang.llvm.org/docs/MemorySanitizer.html#msan-origins) (more detailed traceback about where the undefined value came from) by appending +``` + -fsanitize-memory-track-origins +``` +in the `Makefile` at lines 71 and 72. Note that this may increase runtime heavily. + +Using the [scripts](https://forge.3gpp.org/rep/ivas-codec-pc/ivas-codec/-/wikis/Software-development/pyivastest-howto#how-to-reproduce-tests): + + + +``` +python3 scripts/IvasBuildAndRunChecks.py --checks CLANG1 -m MODE -p /path/to/my/local/ci_linux_ltv_local.json +``` +or directly: + +``` +make clean +make -j CLANG=1 +./IVAS_cod ... +networkSimulator_g192 dly_profile.dat bit bit_err trace_dump 1 +./IVAS_dec ... +``` + + + +/label ~"Priority::Critical" ~Company: ~Subpart: +/label ~Type:Bug ~Status::ToDo diff --git a/.gitlab/issue_templates/usan_ltv_error.md b/.gitlab/issue_templates/usan_ltv_error.md new file mode 100644 index 0000000000..ef6562e866 --- /dev/null +++ b/.gitlab/issue_templates/usan_ltv_error.md @@ -0,0 +1,39 @@ +### Basic info + +- Commit SHA: + +### Bug description + +Clang USAN sanitizer test in pipeline found an error: + + +``` + +``` + + +Link to test pipeline: XXX + +### Ways to reproduce + +Using the [scripts](https://forge.3gpp.org/rep/ivas-codec-pc/ivas-codec/-/wikis/Software-development/pyivastest-howto#how-to-reproduce-tests): + + +``` +python3 scripts/IvasBuildAndRunChecks.py --checks CLANG3 -m MODE -p /path/to/my/local/ci_linux_ltv_local.json --usan_supp_file scripts/ubsan.supp +``` +or directly: + +``` +make clean +make -j CLANG=3 +./IVAS_cod ... +networkSimulator_g192 dly_profile.dat bit bit_err trace_dump 1 +./IVAS_dec ... +``` + + + +/label ~"Priority::Critical" ~Company: ~Subpart: +/label ~Type:Bug ~Status::ToDo -- GitLab From 5a208f272c7ccfc8ab66429a51babb46e8573e68 Mon Sep 17 00:00:00 2001 From: knj Date: Mon, 26 Feb 2024 09:06:16 +0100 Subject: [PATCH 7/7] remove obsolete part of template --- .gitlab/issue_templates/asan_ltv_error.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/issue_templates/asan_ltv_error.md b/.gitlab/issue_templates/asan_ltv_error.md index efb359f539..97b3fa9ec2 100644 --- a/.gitlab/issue_templates/asan_ltv_error.md +++ b/.gitlab/issue_templates/asan_ltv_error.md @@ -20,7 +20,7 @@ Using the [scripts](https://forge.3gpp.org/rep/ivas-codec-pc/ivas-codec/-/wikis/ ``` -python3 scripts/IvasBuildAndRunChecks.py --checks CLANG2 -m MODE -p /path/to/my/local/ci_linux_ltv_local.json --usan_supp_file scripts/ubsan.supp +python3 scripts/IvasBuildAndRunChecks.py --checks CLANG2 -m MODE -p /path/to/my/local/ci_linux_ltv_local.json ``` or directly: -- GitLab